Fix permission for pull request labelling script - #61525
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
SomeoneToIgnore
approved these changes
Jul 23, 2026
zelenenka
added
the
staff
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
While its the `issues` API we use for labelling, it seems that GitHub still wants PR permissions for those. Hence, fixing here. Release Notes: - N/A
pixel365
pushed a commit
to pixel365/zed
that referenced
this pull request
Aug 10, 2026
Now, this is one of these beautiful cases where GitHubs API ist just so pleasant to work with: Because PRs are treated as issues, assigning an assignee to a PR suddenly requires issue write permissions, despite the issue in question being a PR. Not having that permission resulted in some missing assignees on zed zippy bumps and failures of the workflows as seen in https://github.com/zed-industries/zed/actions/runs/31339736929/job/93311493258. In comparison, labelling PRs requires PR write permissions as seen in zed-industries#61525 🤡 Beautiful API and a pleasure to work with, 10/10 would recommend. Release Notes: - N/A
playdohface
pushed a commit
to playdohface/zed
that referenced
this pull request
Aug 29, 2026
While its the `issues` API we use for labelling, it seems that GitHub still wants PR permissions for those. Hence, fixing here. Release Notes: - N/A
playdohface
pushed a commit
to playdohface/zed
that referenced
this pull request
Aug 29, 2026
Now, this is one of these beautiful cases where GitHubs API ist just so pleasant to work with: Because PRs are treated as issues, assigning an assignee to a PR suddenly requires issue write permissions, despite the issue in question being a PR. Not having that permission resulted in some missing assignees on zed zippy bumps and failures of the workflows as seen in https://github.com/zed-industries/zed/actions/runs/31339736929/job/93311493258. In comparison, labelling PRs requires PR write permissions as seen in zed-industries#61525 🤡 Beautiful API and a pleasure to work with, 10/10 would recommend. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While its the
issuesAPI we use for labelling, it seems that GitHub still wants PR permissions for those. Hence, fixing here.Release Notes: